Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the namespace in the client.ListOptions #72

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Pass the namespace in the client.ListOptions #72

merged 1 commit into from
Aug 8, 2019

Conversation

anandswaminathan
Copy link
Contributor

We missed passing namespace to ListOptions.

Thanks @yuchaoran2011 for catching

@mwylde
Copy link
Contributor

mwylde commented Aug 8, 2019

👍

yuchaoran2011
yuchaoran2011 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Then I'll remove this change from my PR.

@anandswaminathan
Copy link
Contributor Author

💨

@anandswaminathan anandswaminathan merged commit f40d052 into master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchaoran2011 yuchaoran2011 yuchaoran2011 approved these changes

@mwylde mwylde mwylde approved these changes

@glaksh100 glaksh100 Awaiting requested review from glaksh100

@kumare3 kumare3 Awaiting requested review from kumare3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandswaminathan @mwylde @yuchaoran2011